laravel / nova-issues

556 stars 34 forks source link

Incorrect Deletion Behavior when Using "Select All Filtered" in Laravel Nova Entity List #5673

Closed fsotomsk closed 1 year ago

fsotomsk commented 1 year ago

Description:

I have identified a bug in Laravel Nova that results in incorrect deletion behavior when filtering entities and using the "Select All Filtered" checkbox. Instead of deleting only the filtered entities, it deletes all records.

Detailed steps to reproduce the issue on a fresh Nova installation:

Expected Behavior:

Only the filtered entities should be deleted, as indicated by the "Select All Filtered" checkbox.

Actual Behavior:

All entities, including those that were not part of the filter, are deleted.

Additional Information:

The bug occurs specifically when the "Select All Filtered" checkbox is checked and the deletion action is triggered. This behavior is inconsistent with the intended functionality of "Select All Filtered," as it should only affect the filtered subset of entities. The bug poses a potential data loss risk, as unintended entities may be deleted when using this feature. This issue affects the latest version of Laravel Nova.

Please address this issue promptly, as it has a significant impact on the reliability and data integrity of applications using Laravel Nova. Let me know if you require any further information or assistance in reproducing the bug.

crynobone commented 1 year ago

We have multiple tests covering this exact use case.

Unable to reproduce the issue, please provide full reproducing repository based on fresh installation as suggested in the bug report template (or you can refer to https://github.com/nova-issues for example)

fsotomsk commented 1 year ago

Upon further investigation, I have determined that the reported behavior in Laravel Nova is not a bug but rather a misunderstanding or misinterpretation on our part. After thoroughly testing the functionality and reviewing the documentation, I have confirmed that the "Select All Filtered" feature in Laravel Nova behaves as intended.

I apologize for any confusion caused by my previous reports. There is no issue with the deletion or unlinking behavior when using filters in Laravel Nova.