Make `$userId` nullable in `ClientRepository->createPersonalAccessClient`

laravel / passport

Laravel Passport provides OAuth2 server support to Laravel.

https://laravel.com/docs/passport

MIT License

3.28k stars 776 forks source link

Make `$userId` nullable in `ClientRepository->createPersonalAccessClient` #1642

Closed bram-pkg closed 1 year ago

bram-pkg commented 1 year ago

Since createPersonalAccessClient and createPasswordGrantClient are both called with null as the $userId and the migrations support this, it would be good to have the docblock in-line with the actual usage of the code.

I'm trying to set up a personal access client in my tests to issue API tokens, and this docblock is incorrect.

driesvints commented 1 year ago

Thanks!