Closed lolsokje closed 11 months ago
drbyte
commented
11 months ago Your post shows that you're running Valet 4.0.0.
The latest is 4.1.4, and a few PRs have been merged to handle a few glitches with custom drivers, including #1414
I suggest running composer global update laravel/valet or just composer global update to get the latest Valet updates. That will help rule out whether the problem has already been addressed.
lolsokje
commented
11 months ago Updated to 4.1.4 but the issue persists.
drbyte
commented
11 months ago You wrote:
I'm extending the LaravelValetDriver as the frontControllerPath method is the same for Symfony as it is for Laravel and can thus be omitted.
While half of that is true, extending the Symfony driver solves the problem.
The following works for me.
-use Valet\Drivers\LaravelValetDriver;
+use Valet\Drivers\Specific\SymfonyValetDriver;
-class CustomValetDriver extends LaravelValetDriver
+class CustomValetDriver extends SymfonyValetDriverEdit: I would recommend renaming from CustomValetDriver to something more context-specific. Or use the LocalValetDriver approach mentioned below...
drbyte
commented
11 months ago FURTHER ...
Since this driver is highly specific to a certain project (referring to your serves() method customizations), why not just call it LocalValetDriver and stick it directly in your project's root directory? That way Valet will look at that first.
-namespace Valet\Drivers\Custom;
+//namespace Valet\Drivers\Custom;
use Valet\Drivers\Specific\SymfonyValetDriver;
-class CustomValetDriver extends SymfonyValetDriver
+class LocalValetDriver extends SymfonyValetDriverAs for serving static assets, you might find some ideas from this post I made responding to someone else's desire for serving static files: https://github.com/laravel/valet/discussions/1430#discussioncomment-6536474
lolsokje
commented
11 months ago You wrote:
I'm extending the LaravelValetDriver as the frontControllerPath method is the same for Symfony as it is for Laravel and can thus be omitted.
While half of that is true, extending the Symfony driver solves the problem.
The following works for me.
-use Valet\Drivers\LaravelValetDriver; +use Valet\Drivers\Specific\SymfonyValetDriver; -class CustomValetDriver extends LaravelValetDriver +class CustomValetDriver extends SymfonyValetDriverEdit: I would recommend renaming from
CustomValetDriverto something more context-specific. Or use the LocalValetDriver approach mentioned below...
Using Valet\Drivers\Specific\SymfonyValetDriver indeed fixed the issue! I tried using Valet\Drivers\SymfonyValetDriver already but the class couldn't be found, I forgot to check what namespace the framework specific drivers have though, that's my bad. Although maybe it could be mentioned more clearly in the documentation.
The driver already has a specific name, I simply chose CustomValetDriver for anonymity sake.
FURTHER ...
Since this driver is highly specific to a certain project (referring to your
serves()method customizations), why not just call itLocalValetDriverand stick it directly in your project's root directory? That way Valet will look at that first.-namespace Valet\Drivers\Custom; +//namespace Valet\Drivers\Custom; use Valet\Drivers\Specific\SymfonyValetDriver; -class CustomValetDriver extends SymfonyValetDriver +class LocalValetDriver extends SymfonyValetDriver
Right now it's only one project using this custom driver, but in the future I'll need to re-use it for others, so I'm not using a local driver for that reason. I'll simply rewrite the serves method when necessary.
drbyte
commented
11 months ago Right now it's only one project using this custom driver, but in the future I'll need to re-use it for others, so I'm not using a local driver for that reason. I'll simply rewrite the serves method when necessary.
Fair. You might be able to simply have the serves() method return true if it's a LocalValetDriver file, since it looks at that file first. Then even fewer rewrites required between projects ;)
Description
I've created the following custom driver in
~/.config/valet/Drivers, as I need to handle static files in a specific manner;I'm extending the
LaravelValetDriveras thefrontControllerPathmethod is the same for Symfony as it is for Laravel and can thus be omitted.The driver is picked up correctly, but gives me the following error;
Without the custom driver, or even when extending the base
ValetDriverclass, the site loads fine but assets don't work (which is why I need the custom driver in the first place).Steps To Reproduce
symfony new [project] --webappvalet linkDiagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
{ "tld": "test", "loopback": "127.0.0.1", "paths": [ "/Users/alex/.config/valet/Sites" ] }cat ~/.composer/composer.json
{ "require": { "laravel/valet": "^4.0", "laravel/installer": "^4.2" } }composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
PHP 8.2.7 (cli) (built: Jun 17 2023 07:09:27) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.7, Copyright (c) Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethanswhich -a php
php --ini
nginx -v
curl --version
php --ri curl
/opt/homebrew/bin/ngrok version
ls -al ~/.ngrok2
brew info nginx
==> nginx: stable 1.25.2 (bottled), HEAD HTTP(S) server and reverse proxy, and IMAP/POP3 proxy server https://nginx.org/ /opt/homebrew/Cellar/nginx/1.25.1 (26 files, 2.4MB) * Poured from bottle using the formulae.brew.sh API on 2023-06-17 at 18:26:29 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/n/nginx.rb License: BSD-2-Clause ==> Dependencies Required: openssl@3, pcre2 ==> Options --HEAD Install HEAD version ==> Caveats Docroot is: /opt/homebrew/var/www The default port has been set in /opt/homebrew/etc/nginx/nginx.conf to 8080 so that nginx can run without sudo. nginx will load all files in /opt/homebrew/etc/nginx/servers/. To start nginx now and restart at login: brew services start nginx Or, if you don't want/need a background service you can just run: /opt/homebrew/opt/nginx/bin/nginx -g daemon off; ==> Analytics install: 15,483 (30 days), 58,119 (90 days), 88,930 (365 days) install-on-request: 15,454 (30 days), 58,026 (90 days), 88,800 (365 days) build-error: 6 (30 days)brew info php
==> php: stable 8.2.9 (bottled), HEAD General-purpose scripting language https://www.php.net/ /opt/homebrew/Cellar/php/8.2.7_1 (529 files, 84MB) * Poured from bottle on 2023-06-17 at 18:26:36 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/p/php.rb License: PHP-3.01 ==> Dependencies Build: httpd, pkg-config Required: apr, apr-util, argon2, aspell, autoconf, curl, freetds, gd, gettext, gmp, icu4c, krb5, libpq, libsodium, libzip, oniguruma, openldap, openssl@3, pcre2, sqlite, tidy-html5, unixodbc ==> Options --HEAD Install HEAD version ==> Caveats To enable PHP in Apache add the following to httpd.conf and restart Apache: LoadModule php_module /opt/homebrew/opt/php/lib/httpd/modules/libphp.so
SetHandler application/x-httpd-php
Finally, check DirectoryIndex includes index.php
DirectoryIndex index.php index.html
The php.ini and php-fpm.ini file can be found in:
/opt/homebrew/etc/php/8.2/
To restart php after an upgrade:
brew services restart php
Or, if you don't want/need a background service you can just run:
/opt/homebrew/opt/php/sbin/php-fpm --nodaemonize
==> Analytics
install: 42,676 (30 days), 150,535 (90 days), 248,957 (365 days)
install-on-request: 39,949 (30 days), 139,747 (90 days), 230,777 (365 days)
build-error: 44 (30 days)brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/opt/homebrew/opt/php/sbin/php-fpm -v
PHP 8.2.7 (fpm-fcgi) (built: Jun 17 2023 07:09:29) Copyright (c) The PHP Group Zend Engine v4.2.7, Copyright (c) Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethanssudo /opt/homebrew/opt/php/sbin/php-fpm -y /opt/homebrew/etc/php/8.2/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -al /Library/LaunchDaemons | grep "com.laravel.valet."
ls -aln /etc/resolv.conf
cat /etc/resolv.conf
ifconfig lo0
sh -c 'echo "------\n/opt/homebrew/etc/nginx/valet/valet.conf\n---\n"; cat /opt/homebrew/etc/nginx/valet/valet.conf | grep -n "# valet loopback"; echo "\n------\n"'
sh -c 'for file in ~/.config/valet/dnsmasq.d/*; do echo "------\n~/.config/valet/dnsmasq.d/$(basename $file)\n---\n"; cat $file; echo "\n------\n"; done'
sh -c 'for file in ~/.config/valet/nginx/*; do echo "------\n~/.config/valet/nginx/$(basename $file)\n---\n"; cat $file | grep -n "# valet loopback"; echo "\n------\n"; done'