michaellehmkuhl
commented
3 days ago Can confirm that this behavior occurs with both valet link --secure and valet proxy --secure.
Open mitchkramez opened 3 days ago
michaellehmkuhl
commented
3 days ago Can confirm that this behavior occurs with both valet link --secure and valet proxy --secure.
michaellehmkuhl
commented
3 days ago It appears that the regex in Site.php includes ssl http2 in the pattern, but the actual secure.valet.conf template file does not have the http2 parameter, so the regex does not match.
Description
When linking a new secured vhost,
valet link domain-name --securethe new nginx config is generated, however, if you've configured the loopback withvalet loopback 10.254.254.254the new nginx config that's created has the correct info replaced in the non ssl server block, but leaves the variable name in place in the :443 server block and has it commented out:Steps To Reproduce
valet loopback 10.254.254.254valet link domain-name --secureand then note the the configuration isn't updating the loopback in the ssl server block in~/.config/valet/Nginx/domain-name.testDiagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
{ "paths": [ "/Users/mitch/.config/valet/Sites" ], "tld": "test", "loopback": "10.254.254.254" }cat ~/.composer/composer.json
{ "require-dev": { "phpstan/phpstan": "^1.10" }, "require": { "laravel/valet": "^4.8" } }composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
PHP 8.2.19 (cli) (built: May 7 2024 14:19:14) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.19, Copyright (c) Zend Technologies with Zend OPcache v8.2.19, Copyright (c), by Zend Technologieswhich -a php
php --ini
nginx -v
curl --version
php --ri curl
/opt/homebrew/bin/ngrok version
ls -al ~/.ngrok2
brew info nginx
==> nginx: stable 1.27.2 (bottled), HEAD HTTP(S) server and reverse proxy, and IMAP/POP3 proxy server https://nginx.org/ Installed /opt/homebrew/Cellar/nginx/1.25.1_1 (23 files, 2.4MB) Built from source /opt/homebrew/Cellar/nginx/1.25.5 (26 files, 2.4MB) * Poured from bottle using the formulae.brew.sh API on 2024-04-26 at 15:31:59 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/n/nginx.rb License: BSD-2-Clause ==> Dependencies Required: openssl@3, pcre2 ==> Options --HEAD Install HEAD version ==> Caveats Docroot is: /opt/homebrew/var/www The default port has been set in /opt/homebrew/etc/nginx/nginx.conf to 8080 so that nginx can run without sudo. nginx will load all files in /opt/homebrew/etc/nginx/servers/. To start nginx now and restart at login: brew services start nginx Or, if you don't want/need a background service you can just run: /opt/homebrew/opt/nginx/bin/nginx -g daemon\ off\; ==> Analytics install: 10,591 (30 days), 38,009 (90 days), 158,767 (365 days) install-on-request: 10,585 (30 days), 37,966 (90 days), 158,347 (365 days) build-error: 28 (30 days)brew info php
==> php: stable 8.4.1 (bottled), HEAD General-purpose scripting language https://www.php.net/ Installed /opt/homebrew/Cellar/php/8.2.8 (518 files, 83.5MB) Built from source /opt/homebrew/Cellar/php/8.3.6 (521 files, 88.7MB) Built from source /opt/homebrew/Cellar/php/8.3.8 (525 files, 88.8MB) Poured from bottle using the formulae.brew.sh API on 2024-06-17 at 09:22:48 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/p/php.rb License: PHP-3.01 ==> Dependencies Build: httpd, pkgconf Required: apr, apr-util, argon2, aspell, autoconf, curl, freetds, gd, gettext, gmp, icu4c@76, krb5, libpq, libsodium, libzip, oniguruma, openldap, openssl@3, pcre2, sqlite, tidy-html5, unixodbc ==> Options --HEAD Install HEAD version ==> Caveats To enable PHP in Apache add the following to httpd.conf and restart Apache: LoadModule php_module /opt/homebrew/opt/php/lib/httpd/modules/libphp.so
SetHandler application/x-httpd-php
Finally, check DirectoryIndex includes index.php
DirectoryIndex index.php index.html
The php.ini and php-fpm.ini file can be found in:
/opt/homebrew/etc/php/8.4/
To start php now and restart at login:
brew services start php
Or, if you don't want/need a background service you can just run:
/opt/homebrew/opt/php/sbin/php-fpm --nodaemonize
==> Analytics
install: 59,034 (30 days), 173,542 (90 days), 676,076 (365 days)
install-on-request: 55,048 (30 days), 161,959 (90 days), 630,537 (365 days)
build-error: 61 (30 days)brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/opt/homebrew/opt/php/sbin/php-fpm -v
PHP 8.3.8 (fpm-fcgi) (built: Jun 4 2024 14:53:17) Copyright (c) The PHP Group Zend Engine v4.3.8, Copyright (c) Zend Technologies with Zend OPcache v8.3.8, Copyright (c), by Zend Technologiessudo /opt/homebrew/opt/php/sbin/php-fpm -y /opt/homebrew/etc/php/8.2/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -al /Library/LaunchDaemons | grep "com.laravel.valet."
ls -aln /etc/resolv.conf
cat /etc/resolv.conf
ifconfig lo0
sh -c 'echo "------\n/opt/homebrew/etc/nginx/valet/valet.conf\n---\n"; cat /opt/homebrew/etc/nginx/valet/valet.conf | grep -n "# valet loopback"; echo "\n------\n"'
sh -c 'for file in ~/.config/valet/dnsmasq.d/*; do echo "------\n~/.config/valet/dnsmasq.d/$(basename $file)\n---\n"; cat $file; echo "\n------\n"; done'
sh -c 'for file in ~/.config/valet/nginx/*; do echo "------\n~/.config/valet/nginx/$(basename $file)\n---\n"; cat $file | grep -n "# valet loopback"; echo "\n------\n"; done'