Open sbcgua opened 5 years ago
which parts to include: why? currently abapmerge merges everything, guess it should be the same with dependencies?
I can use just one util class. Or I can include functionality but don't what to include unit tests. Or the package can contain an example-of-usage program. It's just from the top of my head - for sure there can be more scenarios. For sure not all.
I actually think that including all for the main package is also too harsh, but don't have a case yet :) It will certainly come if abapmerge is more widely used
just rm zfile.prog.abap
before running abapmerge
, with pragmas the source repo will anyhow have to know the objects from the dependency in order to add pragmas
But why ? Merging all does not have any benefits, or ? This is just a support heuristic to validate the integrity and quite indirect one by the way - I would better run abaplint over the final file.
Another option is to add abapmerge.json for config of includes. But currently I feel that in-code reference should be better.
Related to https://github.com/larshp/abapGit/issues/2236
Proposed logic:
.abapgit
dependencies in a special folder e.g..abapmerge_libs
or.abapmerge_modules
or.abapmerge_dependencies
.abapgit
of libs to identify source rootinclude zblahblah_from_another_proj. "@@abapmerge lib
"@@abapmerge lib_class zfoo_class
or"@@abapmerge lib zfoo_class.clas
(as there may be interfaces, so the extension will explain)P.S. currently pragma
include
is used for JS/CSS. I think it would fit better for the dependencies. And for JS/CSS pragma can be renamed toinline
. Hopefully it is safe ... hopefully noone uses abapmerge yet except AG ... or maybe stick withlib
, but I would still rename current include to inline to avoid confusion