search

larsjanssen6 / underconstruction

This Laravel 8 package makes it possible for you to set your website in "Under Construction" mode. Only users with the correct 4 (or more) digit code can access your site. :fire: :boom: :fire:
MIT License
565 stars 68 forks source link

Disable selectable button labels #98

Closed roenfeldt closed 4 years ago

roenfeldt commented 4 years ago

Awesome package, I just love it @larsjanssen6! The only thing I don't like, is the fact that the buttons' labels can be selected, and it stays selected, even when unintentionally selected. For the record, I'm on a MacBook Pro, using the built-in trackpad. See below. Screen Shot 2020-03-18 at 22 24 52 This annoying thing happens very often, when I'm clicking any of the buttons. Is there any way that you can update the package, so that the buttons' label elements have attached the CSS declarations below? -webkit-user-select: none; -moz-user-select: none; -ms-user-select: none; user-select: none;

Thanks a lot.

larsjanssen6 commented 4 years ago

@roenfeldt sure can you make a PR?

roenfeldt commented 4 years ago

@larsjanssen6 I'd love to, but I must confess that I'm pretty new to GitHub, still trying to learn the ropes around here =) and, as an unfortunate consequence, I ended up at the Compare changes screen. I've got no clue about what do do further. I'd highly appreciate any help.

roenfeldt commented 4 years ago

@larsjanssen6 I tried to figure out the issue on my own, by digging into the code of the vendor/larsjanssen6/underconstruction/resources/assets/UnderConstruction.vue file, and adding the CSS rules below line 352 but it doesn't seem to produce any results. Is it even the appropriate place to do it?

I've never worked with Vue - apologies if my question is ridiculous.

larsjanssen6 commented 4 years ago

@roenfeldt hey, I will add it tomorrow 👍

larsjanssen6 commented 4 years ago
larsjanssen6 commented 4 years ago

@roenfeldt hey! it's fixed now see:

https://github.com/larsjanssen6/underconstruction/commit/90c1a4d9e202924e1ba0ab4465a94b223db3e3fe

Don't forget to run composer update 😉

roenfeldt commented 4 years ago

@roenfeldt hey! it's fixed now see:

90c1a4d

Don't forget to run composer update 😉

Outstanding ⭐️ One coffee coming your way 😊

larsjanssen6 commented 4 years ago

@roenfeldt That's awesome! Thanks a lot