search

larvalabs / breaker

Chat rooms for subreddits.
http://www.breakerapp.com
20 stars 3 forks source link

Allow mods and admins to delete messages in rooms #58

Closed megamattron closed 8 years ago

megamattron commented 8 years ago

Add delete button to interface (placement is a beat weak atm). Handle deleted flag in initial state, reducers, message update handlers. Add server delete API endpoint.

This is a fix for #25.

@rickhanlonii - do you want to take a look at this before I merge it? It's my first end-to-end change through server - reducers - UI and so on.

megamattron commented 8 years ago

Should I just merge this @rickhanlonii ? For better or worse...

rickhanlonii commented 8 years ago

@megamattron looks good, I left a few non-blocking comments

megamattron commented 8 years ago

Ran into a few problemos filtering out the deleted messages so opted instead to just render recent messages as deleted. They get fully filtered as they head into history. Gonna release this and see what goes wrong.

megamattron commented 8 years ago

BTW, something I did in here seems to have broken message grouping. It was attributing messages to other users so I rolled back the server to a previous version. Haven't looked into it in detail yet.