lassekongo83 / adw-gtk3

The theme from libadwaita ported to GTK-3
GNU Lesser General Public License v2.1
1.55k stars 57 forks source link

Doesn't theme Phosh's new power menu properly #231

Closed julianfairfax closed 1 year ago

julianfairfax commented 1 year ago

Prerequisites

Checklist to make sure the issue is not on your end

Description

Phosh's new power menu isn't properly themed. However, if it's possible, I think the best solution would be for adw-gtk3 to specifically not theme any Phosh components. Phosh may be GTK3, but it's design is perfectly fine, and ideally, shouldn't be touched by this theme.

OS and version [e.g Fedora 37]

Arch Linux

Adw-gtk3 version. Also specify your installation source. [e.g tar.xz, AUR, git main branch]

latest release at time of writing

GNOME version

No response

Application name and version (If the issue is with an app.)

No response

julianfairfax commented 1 year ago

It actually seems I was wrong about this. The power menu looks fine now. However, I don't think your theme did much to Phosh anyway, and it doesn't theme GNOME Shell, so I'm sure your removal will look fine (I see no difference).

Btw, the theme doesn't build right now:

ninja: Entering directory `build'
[1/3] Generating gtk/src/adw-gtk3/gtk-...enerate_gtk-dark with a custom command
FAILED: gtk/src/adw-gtk3/gtk-3.0/gtk-dark.css 
/usr/bin/sassc -M -t compact ../gtk/src/adw-gtk3/gtk-3.0/gtk-dark.scss gtk/src/adw-gtk3/gtk-3.0/gtk-dark.css
Error: File to import not found or unreadable: phosh.
        on line 14:1 of ../gtk/src/adw-gtk3/gtk-3.0/gtk-dark.scss
>> @import 'phosh';

   ^
[2/3] Generating gtk/src/adw-gtk3/gtk-3.0/generate_gtk with a custom command
ninja: build stopped: subcommand failed.