lassekongo83 / adw-gtk3

The theme from libadwaita ported to GTK-3
GNU Lesser General Public License v2.1
1.55k stars 57 forks source link

Geary sidebar looks broken #241

Closed kk-mofux closed 1 year ago

kk-mofux commented 1 year ago

Prerequisites

Checklist to make sure the issue is not on your end

Description

The Sidebar in Geary is very dark now compared to older versions. Also there is a status area at the bottom of it not matching the background of the sidebar which makes it look broken.

geary-sidebar

OS and version [e.g Fedora 37]

Arch Linux

Adw-gtk3 version. Also specify your installation source. [e.g tar.xz, AUR, git main branch]

4.9-1

GNOME version

44.4

Application name and version (If the issue is with an app.)

Geary 44.1

lassekongo83 commented 1 year ago

Sidebars are now using the same colors as libadwaita 1.4. You can change it if you want. Open ~/.config/gtk-3.0/gtk.css and add @define-color sidebar_bg_color @window_bg_color; and relog/killall geary. As for the bottom area, that may be because of Geary not expanding the sidebar all the way. But it is hard to know as I don't know how to use Geary without an email account.

julianfairfax commented 1 year ago

As for the bottom area, that may be because of Geary not expanding the sidebar all the way. But it is hard to know as I don't know how to use Geary without an email account.

I tried to open the GTK inspector in Geary, but neither Control + Shift + I nor Control + Shift + D work. It must be possible though, and then the issue can be figured out.

lassekongo83 commented 1 year ago

Did you set the key bind? gsettings set org.gtk.Settings.Debug enable-inspector-keybinding true

Otherwise launch the app with GTK_DEBUG=interactive geary

julianfairfax commented 1 year ago

Alright, after doing that it worked.

I'm not sure if this helps, but this is the general structure we're dealing with.

Screencast from 2023-09-16 09-07-19.webm

lassekongo83 commented 1 year ago

Does anything happen if you add .geary-folder + statusbar { background-color: pink; } to ~/.config/gtk-3.0/gtk.css? (Note that the app need to be completely restarted for the changes to take effect: killall geary)

julianfairfax commented 1 year ago

Yes, but it only affects the second element in the video, which is not the full statusbar. You will need to apply the changes to the folder-box element above it (I don't know its CSS class). The scrolled window (with the mailboxes) should retain its current colour as it on top of the folder-box.

julianfairfax commented 1 year ago

Version 5.0 (from Flathub) did not fix this for me. I logged out and logged back in. Still looks broken.

julianfairfax commented 1 year ago

@lassekongo83 the code you had me try was for .geary-folder + statusbar, whereas your code is for .geary-folder. Could this be the issue?

lassekongo83 commented 1 year ago

Know of any free and quick test mail (without phone number check) I can use to access the full interface? It's kind of hard to test anything now.

przmkg commented 1 year ago

@lassekongo83 I can create a testing account on my domain where you'll be able to use imap & smtp. I'll send you a private message on Lemmy.

lassekongo83 commented 1 year ago

@przmkg Thanks.

For this app it was possible to mimic the new libadwaita 1.4 style.

kk-mofux commented 1 year ago

@lassekongo83 Thanks for your continued efforts! Will test when it's available in a release.

julianfairfax commented 1 year ago

Any chance for a hotfix release? This was supposed to have already been fixed, and I don't really want to wait another month or two to get it :(

kk-mofux commented 1 year ago

Just got the update, it looks great!