hoanle
commented
8 years ago @lasthulk
Week 1: Instagram Viewer
:+1: thank you for your submission. The goal of this homework was to teach you RelativeLayout, ListView, networking with APIs, and loading remote images. These concepts are the foundation of nearly every app.
The app looks nice
A few notes after checking out the code:
- Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
- Although the project is small-size, you should consider better organizing your source files
- Good to see you playing around with different layouts, views. Especially on RelativeLayout which is a popular and powerful one.
- You could reuse layout by using include tag. Currently both photo and comment using the same layout. Reuse it
- Consider overriding onFailure method in to handle network failures appropriately.
- Nice usage of RecyclerView with ViewHolder
- Nice to see you used the SwipeRefreshLayout for easy stream refreshes
- Good to see that you were able to successfully read the json object to display comments for photos. But i don't think it contains all comments
- Good job using the ButterKnife library annotations for declaring handles to view objects.
You can read a detailed Project 1 Feedback Guide here which covers the most common points we see for this project, if you'd like to evaluate yourself further.
lasthulk
My app is complete, please review it. /cc @coderschoolreview Thanks