Project ToDo App - Review my app

[lasthulk]

My app is complete, please review. Thanks /cc @codepath

[hoanle]

hi @lasthulk

Thanks for the submission

In general

• The app works fine without any critical issue (such as crash app)
• Required features are done

Detail & suggestion

• Without checking empty title, i can now simply click on ADD button to create many empty items
• I saw your ToDoItemsDbHelper class and even saw its instantiation in the MainActivity, but why you did not use it for storing the data? You're still using file to store
• There are several ways to improve your submission such as: Using SQLite database, writing your own adapter, using DialogFragment...

[lasthulk]

Shame on me. I used source tree to commit source code to github, but I didn't click the push button on the toolbar @hoanle

[lasthulk]

add /cc @coderschoolreview

[coderschoolreview]

Thank you for your Android submission, lasthulk!

:frowning: Unfortunately there are some problems with your submission:

• I couldn't find how much time you spent on the assignment. Please include the number of hours spent on your assignment in your README.md.

[lasthulk]

Hi I have just updated read me file. Thanks for your review /cc @coderschoolreview

[coderschoolreview]

Thank you for your Android submission, lasthulk!

:tada: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

[lasthulk]

Thank you so much.

[chug2k]

lasthulk can you email your name and email address to android {at} coderschool.vn? Are you a CoderSchool student or a CodePath student? =)

[lasthulk]

I am a coderschool.vn student.

[chug2k]

Can you please email android {at} coderschool.vn with your name? I don't have you in our system.

[lasthulk]

Hi chug2k, I have just sent an email to android@coderschool.vn. Can you see it ?

[hoanle]

@lasthulk

Sorry for late reply. Since there is confusion whether you are applying to coderschool or codepath. Now it's clear

About your code:

• App works fine without any critical problem (like crash)
• You have finished required features.
• Some optional tasks are done such as: Using SQLite to store database, using DialogFragment, writing your own adapter

My suggestions:

• Your adapter can be improved more by using ViewHolder
• Every time you delete or edit an item, you use populateTasks(). It retrieves all the records from database and populate to the list. It's not incorrect but it's not the best solution. For example, after deleting an item, you can simply remove it from current item list and the notify the adapter (of course you still need to remove it from database). The advantage is that app does not need to get record from database one more time
• EditItemActivity is no longer used. Remove it so that it won't make confusion
• There are some code can be changed to be prettier. Such as

if (taskName.isEmpty() == false) ==> if (!taskName.isEmpty())

[lasthulk]

Hi @hoanle Thank you for your suggestions. I will update source code later.

[lasthulk]

Hi @hoanle Following your suggestions, I have updated my project. And I also received an CoderSchool Android Bootcamp, Accepted Confirmation. :+1: Thanks.