latis-data / latis3

Apache License 2.0
8 stars 1 forks source link

Bin width #734

Closed dlindhol closed 1 week ago

dlindhol commented 2 weeks ago

This adds binWidth as a first class property of a Scalar variable instead of relying on the mere presence of an uncontrolled binWidth in the metadata. This current change is slightly better than the existing behavior but no worse other than making binWidth explicit might suggest more robust support. Yet to do: Make Scalar construction with binWidth more robust (e.g. NumericType) and add support for Time variables with string types (defaulting to ms) and ISO 8601 durations. We also need to make sure that operations that change the units (e.g. ConvertTime) will also change the binWidth.

This also changes the behavior of the exclusive > and < selection operators. These need to match partially overlapping bins to support granule list datasets. We are currently losing all the matching samples from a file when the selected value is within its time bounds.