search

launchableinc / cli

Launchable CLI
https://pypi.org/project/launchable/
Apache License 2.0
24 stars 13 forks source link

Add assertion to check if the order of test paths is correct #856

Closed ono-max closed 6 months ago

ono-max commented 6 months ago

Currently, we do not verify the order of JSON at https://github.com/launchableinc/cli/blob/main/tests/cli_test_case.py#L221 because we evaluate JSON in an order-agnostic manner. However, we aim to ensure the order of test paths is accurate. assert_json_orderless_equal disregards the order of items intentionally. Consequently, I have introduced the assert_test_path_orderly_equal method to address this requirement, instead of modifying assert_json_orderless_equal.

@kohsuke

I think you designed these methods in https://github.com/launchableinc/cli/pull/91. Can you take a look at this PR?

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

kohsuke commented 6 months ago

Thanks! There's some loose ends when duplicates are present but now the intent is clar, so that's OK for now.