search

launchdarkly / rust-server-sdk

LaunchDarkly Server-Side SDK for Rust
https://docs.launchdarkly.com/sdk/server-side/rust
Other
18 stars 13 forks source link

Trim transitive dependencies - replace use of "built" crate with CARGO_PKG_VERSION #43

Closed markdingram closed 1 year ago

markdingram commented 1 year ago

Is your feature request related to a problem? Please describe.

This SDK currently uses "built" which has a few extra deps & a build script.

Appears lightly used: https://github.com/launchdarkly/rust-server-sdk/blob/69cb1cc4c46ce9b1171769e3ede3ae88191507d8/launchdarkly-server-sdk/src/version.rs

Seems like this could straightforwardly be replaced to reduce the transitive dependency impact on clients using this crate?

Describe the solution you'd like

Drop "built" crate, use Cargo variable CARGO_PKG_VERSION.

https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates

keelerm84 commented 1 year ago

Thank you for raising this issue. I will take a look and update you once we have this resolved!

keelerm84 commented 1 year ago

Addressed in 1.1.2. Thank you again for this issue!