Missing options to individually remove deleted notebooks (and notes on Android) from trash

Terrance commented 4 months ago

Operating system

Windows

Joplin version

3.0.12 (Windows), 3.0.7 (Android)

Desktop version info

Joplin 3.0.12 (prod, win32)

Client ID: 2ca5a676b7954ae89721faa06464e5e6
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: a64d6e3

Backup: 1.4.1
Cursor Sync: 2.1.0
Get Notebook ID: 1.0.1
Joplin Calendar: 1.2.0
Joplin Note Attachement rename: 1.2.2
Kanban: 1.0.7
Note overview: 1.7.1
Outline: 1.5.13

Joplin 3.0.7 (prod, android)

Client ID: d8e98c66054049f0b59e6d8c0db590b2
Sync Version: 3
Profile Version: 47
Keychain Supported: No

Joplin Calendar: 1.2.0
Outline: 1.5.13

Android API level: 33
WebView version: 126.0.6478.134
WebView package: com.google.android.webview
FTS enabled: 1
Hermes enabled: 1

Current behaviour

Delete a notebook
Right-click / long-press that notebook under Trash

On Android, long-pressing a notebook only offers Remove or Cancel options. Long-pressing a note selects it, and the top bar only includes a restore option; the Delete submenu item is also disabled whilst the note is in the trash.

Expected behaviour

On desktop, notes themselves have two options: Restore note and Permanently delete note; I'd expect both notes and notebooks to have these options on all platforms.

Logs

No response

github-actions[bot] commented 3 months ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Terrance commented 3 months ago

PR in progress?

github-actions[bot] commented 2 months ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Terrance commented 2 months ago

Still an issue -- @personalizedrefrigerator, any updates on what you've got so far?

personalizedrefrigerator commented 2 months ago

Still an issue -- @personalizedrefrigerator, any updates on what you've got so far?

The pull request should be ready for review! For testing, I've also deployed a version of the pull request here: https://personalizedrefrigerator.github.io/joplin/web-client/.

Terrance commented 2 months ago

I note the PR described itself as only a partial fix, covering permanent deletion of notes on Android -- it would still be useful to have the ability to delete individual notebooks from the Trash too.

personalizedrefrigerator commented 2 months ago

Re-opening as partially resolved.

laurent22 / joplin