search

laurilehmijoki / s3_website

Manage an S3 website: sync, deliver via CloudFront, benefit from advanced S3 website features.
Other
2.24k stars 187 forks source link

Fall back to default AWS credential provider chain #286

Closed pnc closed 7 years ago

pnc commented 7 years ago

This is my second Scala change ever, so by all means, please provide feedback! I'll fix it up.

http://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/credentials.html

Fixes #262.

pnc commented 7 years ago

Inspired by #238, but tries to preserve backwards compatibility with the old s3_id way of providing credentials.

pnc commented 7 years ago

I've left the commits separate for easier review, but I'm happy to squash if you prefer not to use the GitHub UI for that.

pnc commented 7 years ago

I suppose really the same change ought to be made to the Ruby bits for consistency, so s3_website cfg apply also uses the standard credentials?

laurilehmijoki commented 7 years ago

Care to check if the Ruby component needs to learn this feature as well?

One option is to release this credentials fall back mechanism now in the Scala code and later add it to the Ruby code. Of course for the sake of consistency it would be better to release them together, but if you run out of time, then the Scala modification is an acceptable first step. Or what do you think?

pnc commented 7 years ago

I'd rather do them together, and it shouldn't be too hard to let the Ruby code fall back too. Busy tonight but should be able to do that change this weekend or so.

c0state commented 7 years ago

Btw, I took a crack at the Ruby portion of this change. See https://github.com/laurilehmijoki/configure-s3-website/pull/19

laurilehmijoki commented 7 years ago

Released in 3.2.0. Thank you @pnc and @c0state!

pnc commented 7 years ago

👍👍👍 thanks for maintaining such a handy tool!

Phil

On Aug 8, 2017, at 02:47, Lauri Lehmijoki notifications@github.com wrote:

Released in 3.2.0. Thank you @pnc and @c0state!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.