lausd-teacher / gwt-oauth2

Automatically exported from code.google.com/p/gwt-oauth2
Apache License 2.0
0 stars 0 forks source link

AuthImpl.java uses a hard coded window size for the login window #12

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Use the library to try to log in to an OAuth2 service
2. See that the Window size is always width=800,height=600
3. Cry and create your own version of AuthImpl that makes kittens cry with the 
workaround
4. Enter this report

What is the expected output? What do you see instead?
I would hope that there would be a way to determine how the auth window is 
going to be formatted.

Please provide any additional information below.

The bad person workaround that we implemented is to create our own version of 
AuthImpl which has a member variable for the window dimension string.  This can 
be changed via a setter and is then used on the openWindow call.  Usage of the 
variable resets it to the default (which is the sadness making part).

Original issue reported on code.google.com by philipcr...@gmail.com on 17 Nov 2011 at 6:34

GoogleCodeExporter commented 8 years ago
I definitely don't want to make any kittens cry.

Change incoming to add this feature. Thanks for the report!

Original comment by jasonhall@google.com on 17 Nov 2011 at 6:46

GoogleCodeExporter commented 8 years ago
Done in r38

I can probably put up a new release today, tomorrow at the latest.

Original comment by jasonhall@google.com on 17 Nov 2011 at 8:40