search

lawliet89 / biscuit

JOSE (JSON Web Token) Library for Rust
https://lawliet89.github.io/biscuit
Other
181 stars 35 forks source link

Fill in for `ring`'s deficiencies #42

Open lawliet89 opened 7 years ago

lawliet89 commented 7 years ago

openssl or others.

Maybe gate these behind a feature switch.

Current ring deficiencies that will be addressed:

Not in ring, but "nice to have" for biscuit:

Not in ring, but I am not sure biscuit needs it:

MJDSys commented 7 years ago

Hi @lawliet89,

I started playing with porting the crypto of biscuit to openssl (you can see the result here: https://gitlab.mjdsystems.ca/MJDSys/biscuit-openssl ). I did that as I wanted to tap some crypto currently available in openssl not yet available in Ring. So far I'm just playing with what I need for my projects, but I'd be happy to help bring these changes back into biscuit (behind a feature gate is fine!) if you would like. Do you have any idea of what you would like this support to look like? I was thinking maybe putting all the crypto behind some set of traits, so a user could substitute in their own preferred crypto library in the future, though I fear that might make simple use of the library hard.

One easy thing I could submit as a PR here is removing the constant time equality checks in the unit tests. As they are tests, I don't think we need that to be constant time as they are just tests. I wouldn't change the "real" code, as that would have security implications.

lawliet89 commented 7 years ago

I think gating it behind a feature gate would be fine. The traits idea might be too complicated, you're right. Eventually, I'd like to not use OpenSSL at all and just use everything that ring has to offer.

Sure, a PR would be great if you're up for it.

MJDSys commented 7 years ago

@lawliet89 Sorry, somehow Github never poked me about this comment. I'll see what I can do.

lawliet89 commented 7 years ago

Thanks @MJDSys. Maybe I have to @ ping you to notify you.

Korvox commented 7 years ago

Is there an ugly way to get an rsa pubkey as Vec<u8> from n and e out of a jwk right now without pulling in openssl? I'm going to need to generate rsa keys from JWKs in my work, so if nobody else has a solution I'll bite the bullet.

lawliet89 commented 7 years ago

No. Ring does not have that API last I checked.

On Thu, 24 Aug 2017, 06:24 Matthew Scheirer notifications@github.com wrote:

Is there an ugly way to get an rsa pubkey as Vec from n and e out of a jwk right now without pulling in openssl?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lawliet89/biscuit/issues/42#issuecomment-324480007, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8APUMNFAntINEJe9fvXENZ8eE98PQ-ks5sbKa0gaJpZM4MuUcU .

-- Regards Yong Wen

briansmith commented 7 years ago

Is there an ugly way to get an rsa pubkey as Vec from n and e out of a jwk right now without pulling in openssl? I'm going to need to generate rsa keys from JWKs in my work, so if nobody else has a solution I'll bite the bullet.

If you have n and e from a JWK you can use ring::signature::primitive::verify_rsa to verify the signature directly from them.

If you have n and e and you need to convert them into SPKI form, ring doesn't have any support for encoding the SPKI form now. Similarly, if you have the SPKI form and you need to extract n and e then there's an open PR to add an API for that to ring but I've just not had time to review, update, and merge it. If you know of a potential sponsor for that work then email me at brian@briansmith.org. Similarly for the other features mentioned in the first message above.

briansmith commented 6 years ago

Current ring deficiencies that will be addressed:

ECDSA signing (briansmith/ring#207 and briansmith/ring#209)

ECDSA signing is in ring 0.13.0-alpha4.

LukeMathWalker commented 4 years ago

Hey! I was recently looking for ES512 and I noticed that ring is not planning to support it. Would there still be an interest to support it via openssl behind a feature gate or does it add too much complexity to biscuit?

kinosang commented 3 years ago

Or could we move from ring to RustCrypto, they have rsa and elliptic-curve. If acceptable, I'll try to do so.

nullr0ute commented 1 year ago

ring seems to have many issues and mostly appears to be unmaintained, I think the 3 main other options are the "openssl", "native-tls", or RustCrypto crates so I think it would make sense to look at moving to one of those given that the last stable release of ring was over 2 years ago which means it has 2+ years worth of BoringSSL CVEs unfixed.

briansmith commented 1 year ago

the last stable release of ring was over 2 years ago which means it has 2+ years worth of BoringSSL CVEs unfixed.

AFAIK, there were no bugs inherited from BoringSSL that required fixes to be backported to the stable release. That's a good thing.