lawremi / PerFabricaAdAstra

Through crafting, to the stars
http://pfaa.wikia.com/
Artistic License 2.0
17 stars 7 forks source link

Feature Request: separate overlays for types of brick, rubble, and cobblestone #52

Open MauveCloud opened 8 years ago

MauveCloud commented 8 years ago

According to the changelog, cobble, brick, and rubble are rendered as overlays as of 0.2.12, with one overlay for cobble, one for brick, and one for rubble, regardless of which stone type is involved. However, this doesn't look as good as having separate textures for each type of cobble, each type of brick, etc., and seems unnecessary when there are only 25 types of rock. Also, I know of one texture pack that already includes separate textures for most of the cobblestones and bricks, which are no longer used (and it would be a hassle to rework them to look good with the new overlay system): http://bdcraft.net/community/pbdc-patches-wip/per-fabrica-astra-geologica-t3309.html Thus, it would be nice to have an option for picking up these textures, with a fallback to the overlay system for blocks that don't have specific cobble/brick/rubble textures.

lawremi commented 8 years ago

This would require a reliable/clean way to detect whether a particular texture resource is available. This post contains one solution, although it breaks abstraction somewhat by building the path explicitly. But this is Minecraft modding after all..

MauveCloud commented 8 years ago

Okay, I won't insist on the fallback part, but I can think of a couple alternatives:

  1. Use separate files for overlays of different stone types, which can be identical across stone types for the mod's default textures, but still make it possible for a resource pack to make them more distinct (e.g. by filling the entire overlay as you suggested in the forum thread).
  2. Make it the player's responsibility to make sure distinct textures are available when enabled in the config.