search

lawsie / guizero

A Python 3 library to allow learners to quickly and easily create GUIs.
https://lawsie.github.io/guizero
BSD 3-Clause "New" or "Revised" License
402 stars 81 forks source link

Add `step` to Slider #510

Closed james-pcdr closed 3 weeks ago

james-pcdr commented 1 month ago

Hello all, Let me know if you have any feedback. Thanks, and thanks for making guizero!

lawsie commented 1 month ago

Hi @james-pcdr thanks for this! It seems like a good idea to me, are you happy @martinohanlon ? Please could you add docs changes and tests to your PR as well? (You only need to change the .md files not the HTML)

james-pcdr commented 1 month ago

@lawsie Sure! So those would be in slider.md and test_slider.py?

martinohanlon commented 1 month ago

Can we add properties to modify the step the same way that exist for start and end? That would make it consistent and allow users to change the step after the widget has been created.

martinohanlon commented 1 month ago

@lawsie Sure! So those would be in slider.md and test_slider.py?

Yes, that is right :)

james-pcdr commented 3 weeks ago

I started a new PR so that it would be a single commit based on the dev branch.