lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.76k stars 262 forks source link

Chat 7tv expression download is not complete, can you add a function? #1228

Open xxxqq55 opened 1 month ago

xxxqq55 commented 1 month ago

Checklist

Write stuff here

chat downloader。My network downloaded 7tv emojis very slowly, resulting in the final download of emojis some download success, some will fail. log error: 7TV returned HTTP. 7TV emotes may not be present for this session.. So if I can't change the Internet environment, can I make the download time longer, or can I add a local emoji library。While I could make all the emojis download correctly by repeatedly enabling chat Render, it was a waste of my time:(

ScrubN commented 1 month ago

You can retry the 7TV download by using the Chat Updater function with either "Embed missing" or "Replace embeds" enabled

xxxqq55 commented 1 month ago

@ScrubN I know about this Chat Updater, which I've already said in the ISSUE. My Internet environment is really bad for 7TV, I need to enable Chat Updater repeatedly to complete all normal downloads, and I have to add chat files repeatedly each time :(

Mishasama commented 1 month ago

You can retry the 7TV download by using the Chat Updater function with either "Embed missing" or "Replace embeds" enabled

When downloading chats, if it failed at the 3rd party phase, the chat file won't be saved even the original chat data was downloaded. So, you won't have a chance to "Update" chat file for missing 3rd emotes. Instead, you have to repeat to download the whole file from the zero again and again.

ScrubN commented 1 month ago

I know about this Chat Updater, which I've already said in the ISSUE. My Internet environment is really bad for 7TV, I need to enable Chat Updater repeatedly to complete all normal downloads, and I have to add chat files repeatedly each time :(

I'll see if I can make it take more than 1 failed request to abort fetching 7TV emotes. It was originally a bandage solution to prevent the download from failing outright when an emote provider was having issues.

ScrubN commented 1 month ago

The chat file even doesn't saved when downloading. Nothing with Chat Updater.

I'm not entirely sure what this is saying. Could you rephrase it?