search

lazarv / react-server

The easiest way to build React apps with server-side rendering
https://react-server.dev
MIT License
118 stars 6 forks source link

Missing css in middleware mode #12

Closed lionelhorn closed 3 months ago

lionelhorn commented 3 months ago

Using your express middleware example, started via express server, the page is missing the css.

https://github.com/lazarv/react-server/blob/ed43f3de0cc468ae4f957b461319e9f70d704ad1/examples/express/package.json#L7-L8

Started with pnpm run dev (middleware mode)

image

Started with pnpm run dev:app

image

Repro at https://github.com/lionelhorn/reproductions/tree/main/lazarv-reactserver-middleware-css

Thanks in advance :)

lazarv commented 3 months ago

I had to fix an AsyncLocalStorage issue in the SSR handler and had to add base path support for style assets, which was missing so far. Latest version is now on npm, so please update and this should work now!

github-actions[bot] commented 2 months ago

This issue has been locked since it has been closed for more than 30 days.

If you have found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest version of @lazarv/react-server. If you have any other comments you should create a new discussion.