lbonn / rofi

Rofi: A window switcher, run dialog and dmenu replacement - fork with wayland support
Other
876 stars 35 forks source link

[BUG] Latest git from this morning seems to have broken `rofi -drun-use-desktop-cache -show drun ` #116

Closed Sinaaaa closed 4 months ago

Sinaaaa commented 4 months ago

Rofi version (rofi -v or git commit in case of build issue)

Rofi version: 1.7.5+wayland2-dev

Configuration

https://gist.github.com/Sinaaaa/34585eff711f9540456dcbbdac4c9eba

Theme

https://gist.github.com/Sinaaaa/1eedf436314d8da1c93daccb969ca2bd

Timing report

No response

Launch command

rofi -drun-use-desktop-cache -show drun

Step to reproduce

Just run rofi -drun-use-desktop-cache -show drun

(this is on x11 right now, I have not tried on wayland yet. I use this fork of rofi on both)

Expected behavior

Normal drun operation.

Actual behavior

screenshot_2024021710:4609

Rofi only displays one item & then freezes for several seconds.

+this right here:

systemd-coredump[22395]: [🡕] Process 22389 (rofi) of user 1000 dumped core.

                                              Stack trace of thread 22389:
                                              #0  0x00007f12f664532c n/a (libc.so.6 + 0x8d32c)
                                              #1  0x00007f12f65f46c8 raise (libc.so.6 + 0x3c6c8)
                                              #2  0x00007f12f65dc4b8 abort (libc.so.6 + 0x244b8)
                                              #3  0x00007f12f6ddd0ee n/a (libglib-2.0.so.0 + 0x1e0ee)
                                              #4  0x00007f12f6e3e220 g_assertion_message_expr (libglib-2.0.so.0 + 0x7f220)
                                              #5  0x0000563f635e3ed8 n/a (rofi + 0x45ed8)
                                              #6  0x0000563f635c5730 process_result (rofi + 0x27730)
                                              #7  0x0000563f635f9396 n/a (rofi + 0x5b396)
                                              #8  0x0000563f635f7c45 n/a (rofi + 0x59c45)
                                              #9  0x0000563f635f5583 n/a (rofi + 0x57583)
                                              #10 0x00007f12f6e18f69 n/a (libglib-2.0.so.0 + 0x59f69)
                                              #11 0x00007f12f6e773a7 n/a (libglib-2.0.so.0 + 0xb83a7)
                                              #12 0x00007f12f6e19b97 g_main_loop_run (libglib-2.0.so.0 + 0x5ab97)
                                              #13 0x0000563f635bd523 main (rofi + 0x1f523)
                                              #14 0x00007f12f65ddcd0 n/a (libc.so.6 + 0x25cd0)
                                              #15 0x00007f12f65ddd8a __libc_start_main (libc.so.6 + 0x25d8a)
                                              #16 0x0000563f635bd765 _start (rofi + 0x1f765)

                                              Stack trace of thread 22390:
                                              #0  0x00007f12f66be88d syscall (libc.so.6 + 0x10688d)
                                              #1  0x00007f12f6e72337 g_cond_wait (libglib-2.0.so.0 + 0xb3337)
                                              #2  0x00007f12f6de41b4 n/a (libglib-2.0.so.0 + 0x251b4)
                                              #3  0x00007f12f6e4cace n/a (libglib-2.0.so.0 + 0x8dace)
                                              #4  0x00007f12f6e4aa45 n/a (libglib-2.0.so.0 + 0x8ba45)
                                              #5  0x00007f12f664355a n/a (libc.so.6 + 0x8b55a)
                                              #6  0x00007f12f66c0a3c n/a (libc.so.6 + 0x108a3c)

                                              Stack trace of thread 22392:
                                              #0  0x00007f12f66b30bf __poll (libc.so.6 + 0xfb0bf)
                                              #1  0x00007f12f6e772f6 n/a (libglib-2.0.so.0 + 0xb82f6)
                                              #2  0x00007f12f6e19b97 g_main_loop_run (libglib-2.0.so.0 + 0x5ab97)
                                              #3  0x00007f12f6bb819c n/a (libgio-2.0.so.0 + 0x11219c)
                                              #4  0x00007f12f6e4aa45 n/a (libglib-2.0.so.0 + 0x8ba45)
                                              #5  0x00007f12f664355a n/a (libc.so.6 + 0x8b55a)
                                              #6  0x00007f12f66c0a3c n/a (libc.so.6 + 0x108a3c)

                                              Stack trace of thread 22393:
                                              #0  0x00007f12f66be88d syscall (libc.so.6 + 0x10688d)
                                              #1  0x00007f12f6e72337 g_cond_wait (libglib-2.0.so.0 + 0xb3337)
                                              #2  0x00007f12f6de41b4 n/a (libglib-2.0.so.0 + 0x251b4)
                                              #3  0x00007f12f6de421c g_async_queue_pop (libglib-2.0.so.0 + 0x2521c)
                                              #4  0x00007f12f5fd8d08 n/a (libpangoft2-1.0.so.0 + 0x8d08)
                                              #5  0x00007f12f6e4aa45 n/a (libglib-2.0.so.0 + 0x8ba45)
                                              #6  0x00007f12f664355a n/a (libc.so.6 + 0x8b55a)
                                              #7  0x00007f12f66c0a3c n/a (libc.so.6 + 0x108a3c)

                                              Stack trace of thread 22391:
                                              #0  0x00007f12f66b30bf __poll (libc.so.6 + 0xfb0bf)
                                              #1  0x00007f12f6e772f6 n/a (libglib-2.0.so.0 + 0xb82f6)
                                              #2  0x00007f12f6e17162 g_main_context_iteration (libglib-2.0.so.0 + 0x58162)
                                              #3  0x00007f12f6e171b2 n/a (libglib-2.0.so.0 + 0x581b2)
                                              #4  0x00007f12f6e4aa45 n/a (libglib-2.0.so.0 + 0x8ba45)
                                              #5  0x00007f12f664355a n/a (libc.so.6 + 0x8b55a)
                                              #6  0x00007f12f66c0a3c n/a (libc.so.6 + 0x108a3c)
                                              ELF object binary architecture: AMD x86-64

Additional information

Up to date Arch btw ..

Using wayland display server protocol

I've checked if the issue exists in the latest stable release

Sinaaaa commented 4 months ago

Of course it's totally fine to ignore this, since it's obviously fine on stable. I'm running the git version, because the window switcher worked much better on it due to some relatively recent changes ^

lbonn commented 4 months ago

Of course it's totally fine to ignore this, since it's obviously fine on stable. I'm running the git version, because the window switcher worked much better on it due to some relatively recent changes

Better not ignore a crash :). It's actually good to have users testing the latest tip, thanks for the report.

There were some changes in the drun cache from rofi upstream that were merged indeed, I think it's coming from there.

Can you try with this branch/commit and see if it solves the issue? https://github.com/lbonn/rofi/commit/3a4981498d694c52bf9ca710a8ccbb6d6f6c7740

lbonn commented 4 months ago

Ok it should be fixed on upstream and this fork, please re-open if you are still having issues.

Sinaaaa commented 4 months ago

Yes, it's fixed. Sorry for not responding earlier, I just arrived home a couple of minutes ago.

Thank you for the great work that you do!

DaveDavenport commented 4 months ago

Thanks for testing git version and reporting issues!