search

lbraglia / RStata

[R package]: A R-Stata interface
110 stars 37 forks source link

Can change foreign to haven? #14

Open yuyangyoung opened 5 years ago

yuyangyoung commented 5 years ago

This package uses foreign. always cause ##empty string is not valid in Stata's documented format. haven::write_dta will not

jackobailey commented 3 years ago

Just to add to this point -- it would be useful to use haven instead of foreign as foreign only supports Stata up to version 7 and we're now on version 15. One annoying feature of using foreign over haven is that it drops value labels, which haven does not. Judging by the code, this would not be a difficult update to make.

hughmarera commented 3 years ago

@jackobailey i think you can make your point without spreading fake news. FYI foreign reads Stata 5-12. See https://cran.r-project.org/web/packages/foreign/

jackobailey commented 3 years ago

@hughmarera And you could be more polite than to accuse someone who made a simple mistake of "spreading fake news".

hughmarera commented 3 years ago

@jackobailey my apologies