search

lchokhoe / pe

0 stars 0 forks source link

Duplicate patron #2

Open lchokhoe opened 2 years ago

lchokhoe commented 2 years ago

Error message when adding in patrons is not explicit in the reason why its considered a duplicate.

Replicating bug: patron add n/Harper Lee s/A0988773M p/91437496 e/harperlee@u.nus.eduuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu patron add n/Harper Lee s/A0988773M p/91437496 e/harperlee@u.nus.eduuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu

image.png

soc-se-bot commented 2 years ago

Team's Response

Thank you for reporting this issue.

image.png

As per the module website, unspecific error messages is at most low severity.

This issue can be solved by adding new error messages for same email, same name and same if respectively in our Message class, and writing a function for printing one of these 3 messages whenever the patron is considered be the same as an existing patron based on isSamePatron() function.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]