search

lcpp-org / RustBCA

A free, open-source Binary Collision Approximation (BCA) code for ion-material interactions including sputtering, implantation, and reflection
https://github.com/lcpp-org/RustBCA/wiki
GNU General Public License v3.0
42 stars 15 forks source link

[bug] Python bindings documentation discrepancy in output position units #204

Closed drobnyjt closed 1 year ago

drobnyjt commented 1 year ago

Description If you call help(compound_bca_list_py), it states the output positions are in Angstroms. They are not - they are in meters. This should be fixed by changing the output units of compound_bca_list_py to match the documentation - since the inputs are given in atomic units (amu, eV, angstrom, etc.) the outputs should be as well.