lcpp-org / RustBCA

A free, open-source Binary Collision Approximation (BCA) code for ion-material interactions including sputtering, implantation, and reflection
https://github.com/lcpp-org/RustBCA/wiki
GNU General Public License v3.0
42 stars 15 forks source link

Weak collision loop updates #219

Closed drobnyjt closed 1 year ago

drobnyjt commented 1 year ago

Thank you for your contribution to rustBCA!

Before submitting this PR, please make sure you have:

Fixes #217

Description

This is another attempt at rearranging the weak collision loop for more clarity. I was unable to measure any changes to the physical results with the more correct subtraction order, but making it clear that the weak collision aren't generating fictional energy is important to long-term maintainability.

Tests

Cargo test has been run.