search

lcpp-org / RustBCA

A free, open-source Binary Collision Approximation (BCA) code for ion-material interactions including sputtering, implantation, and reflection
https://github.com/lcpp-org/RustBCA/wiki
GNU General Public License v3.0
42 stars 15 forks source link

[bug] Direction vector multiplied by length unit when input as points (results unaffected due to later normalization) #228

Closed drobnyjt closed 11 months ago

drobnyjt commented 1 year ago

Description See this line: https://github.com/lcpp-org/RustBCA/blob/9cbede642d9f8bf316b68b7eb4798bb64b9093a2/src/input.rs#L558 ux, uy, and uz should not be multiplied by length_unit. While this doesn't actually have an effect on the results since the direction is normalized when particles are created, it should still be fixed.

drobnyjt commented 11 months ago

Fixed on dev.