search

ldd / fantasy-map-generator

Minimal fantasy map generator
Other
15 stars 4 forks source link

Uglify is breaking the web build #1

Open TehShrike opened 7 years ago

TehShrike commented 7 years ago

If I import the web build in Chrome 56, terrain.min.js throws an error:

Uncaught ReferenceError: Invalid left-hand side expression in postfix operation

If I comment out the webpack.optimize.UglifyJsPlugin instantiation in webpack.web.config.js, then terrain.min.js doesn't throw any errors.

ldd commented 7 years ago

What is your operating system, is it windows by any chance? (I do have a windows machine. It'll take me some time to fix that. In the meantime, uglify should be optional, right? I'll open an issue for that

TehShrike commented 7 years ago

I'm just running the web build in Chrome, I'm not running it in node.

I am running on macOS, though.

ldd commented 7 years ago

Um... I'm also on a mac, and on chrome 56. Did you use the terrain.min.js file from the gh-pages branch? If not, did you make it yourself?

If you made it yourself, I guess that the uglify version might have something to do with it. Can you tell me the result of uglifyjs --version?

TehShrike commented 7 years ago

I ran npm run web to build, yes.

The globally installed version of uglify shouldn't make any difference, since you correctly reference it in your package.json... :-x

The only uglifyjs I have installed globally is the really old one from here.