ldeo-glaciology / xapres

package for processing ApRES data using xarray
MIT License
3 stars 2 forks source link

renaming and slight refactor #24

Closed jkingslake closed 8 months ago

jkingslake commented 1 year ago

Before we go too much further with this package, I think we should do a little refactoring and rename some important things.

@glugeorge @Elizabethcase , what do you think?

Elizabethcase commented 1 year ago

Agree re: renaming package. The sooner the better.

Different libraries could be: load, plot, preprocess (remove noisy chirps, chop clipped signal, check for clippping, etc), processing (could be broken up into time analysis, polarmetric, repeat, and cmp libraries)

jkingslake commented 8 months ago

many of these changes are in PR #35. I did not remove load_all, but I did add a wrapper around the who class, which is attempted to solve the same problem that removing load_all was; i.e. making it simpler to make xarrays from dat files without necessarily having to do the whole OO thing of initializing an object then running its methods.

35 does not change the name of the package, but we should do that next.

jkingslake commented 8 months ago

35 does now change the name of the package to xapres.

and #35 has been merged, so I will close this issue