ldtteam / minecolonies

Minecolonies minecraft mod
http://minecolonies.com/
GNU General Public License v3.0
676 stars 349 forks source link

Debts found during porting #9771

Open Nightenom opened 9 months ago

Nightenom commented 9 months ago

Sorted from highest to lowest "priority":

Nightenom commented 3 months ago

image

uecasm commented 3 months ago

CompostRecipe -> data maps - compostables

I thought about that during the 1.20.4 port, but concluded that it wasn't sufficiently compelling because the existing system allows for automatic addition of items based on food/plant properties, which a data map system would not.

RFC: CustomRecipe -> normal recipe with normal serializers etc. with condition FALSE (so it never works for players), requires datapack breaking change

There's actually no requirement that vanilla recipes be usable by players, so you don't have to do anything special to disable that. There's no particular technical barrier to putting colony recipes into the regular recipe manager, but not really much benefit either. We're already handling synching and we would still require custom handling for loot tables, so it doesn't even let us remove much code.