search

leapdao / bridge-ui

dApp for interacting with LeapDAO chain
https://testnet.leapdao.org
GNU General Public License v3.0
11 stars 5 forks source link

Fix token id for NFTs #263

Closed iamonuwa closed 4 years ago

iamonuwa commented 4 years ago

Fixes #229

troggy commented 4 years ago

@iamonuwa maybe fixes #229 ? :)

iamonuwa commented 4 years ago

if you have some NFT of specified color, AmountInput component will render a select tag, with several options and blank placeholder: image

Please, refer Ant Design Documentation for Select and AmountInput around line 88 to address this issue

I can't reproduce this. Please me know which of the NFTs that does this

MaxStalker commented 4 years ago

All of them :) You just need to have at least 1 token of selected color.

iamonuwa commented 4 years ago

All of them :) You just need to have at least 1 token of selected color.

Is this issue reproducible from the /wallet page?

MaxStalker commented 4 years ago

This is exactly the place, where I got that screenshot from.

iamonuwa commented 4 years ago

This is exactly the place, where I got that screenshot from.

This is what I see image

MaxStalker commented 4 years ago

VOC is not NFT token. Try anything below SDST token in that dropdown

troggy commented 4 years ago

Technically VOC is also NFT (every ERC1948 is NFT afair). However, I think AmountInput renders to select box only for enumerable NFTs.

So it could be both select or text input for NFTs/NSTs

MaxStalker commented 4 years ago

Technically VOC is also NFT (every ERC1948 is NFT afair)

Pretty sure VOC is ERC20 👇 image

iamonuwa commented 4 years ago

@MaxStalker its displayed as NFT.

MaxStalker commented 4 years ago

I am a bit confised about what we are discussing 🤪 @iamonuwa can you put a screenshot of the whole page how it renders for you with proposed changes?

iamonuwa commented 4 years ago

I am a bit confised about what we are discussing 🤪 @iamonuwa can you put a screenshot of the whole page how it renders for you with proposed changes?

Screenshot from 2019-12-16 19-47-07

troggy commented 4 years ago

@MaxStalker you are right, ERC20 😅

MaxStalker commented 4 years ago

Judging by that screenshot - you've picked VOC, which is ERC20 contract (which you can ensure if you go to registerToken and search for VOC - color 4, ERC20 token. That's why input in Transfer tokens section have 0 in it. I've deposited a single TING token to your address. Now, in order to reproduce the "bug" you will need: