search

leapdao / bridge-ui

dApp for interacting with LeapDAO chain
https://testnet.leapdao.org
GNU General Public License v3.0
11 stars 5 forks source link

submit new proposal + first frontend changes #269

Closed simonweniger closed 4 years ago

simonweniger commented 4 years ago

solves #272

troggy commented 4 years ago

@simonweniger I see that you are going step-by-step (e.g. not showing proposals yet). This is fine 👍But I suggest we won't merge intermediate steps into master branch, but rather in some kind of feature branch. E.g. create a branch feature/token-governance and create all your intermediate pull request against it. This way we merge small changes gradually one by one into feature/token-governance and once it is done we do the final merge into master. How does it sound?

simonweniger commented 4 years ago

the idea of feature/token-governance is greate. I am going to do that

troggy commented 4 years ago

contract call fails for me when I try to register a proposal. I have 20000 LEAP on my account, so it is enough for stake and the proposal name and description are pretty unique, so there is no hash collision

simonweniger commented 4 years ago

contract call fails for me when I try to register a proposal. I have 20000 LEAP on my account, so it is enough for stake and the proposal name and description are pretty unique, so there is no hash collision

Did you approved the withdraw of Leap at etherscan ? This feauter where the user can approve the contract to take his Leap isn't build in yet...

troggy commented 4 years ago

Did you approved the withdraw of Leap at etherscan ? This feauter where the user can approve the contract to take his Leap isn't build in yet...

great point! totally overlooked that. Approved the allowance and now it works 🎉

Also used "write" functionality on Etherscan for the first time, cool

troggy commented 4 years ago

@cyan-one I've changed the base branch for this PR from master to feature/token-governance

troggy commented 4 years ago

@cyan-one proposed some changes here: https://github.com/leapdao/bridge-ui/pull/276 (based on top of governance-screen branch, so will be merged here in this PR) Suggesting to merge #276 before merging #269