search

leeenglestone / CodeReviewChecklist

An online checklist guide for performing code reviews
https://www.codereviewchecklist.com
MIT License
13 stars 8 forks source link

Create, upload and reference favicon #19

Closed leeenglestone closed 4 years ago

JamesLedger commented 4 years ago

I've implemented a temporary favicon from the material design specs , what do you think?

leeenglestone commented 4 years ago

Hi @JamesLedger Looks good. I think a lot of user agents look for favicons at the root of the site by default. Can you move the favicon.ico to the root of the site and update the reference?

JamesLedger commented 4 years ago

Ahh I didn't know that! Sure thing I'll sort that

JamesLedger commented 4 years ago

Resolved