search

leeenglestone / CodeReviewChecklist

An online checklist guide for performing code reviews
https://www.codereviewchecklist.com
MIT License
13 stars 8 forks source link

Menu hamburger no longer visible on small screen sizes #38

Closed leeenglestone closed 4 years ago

leeenglestone commented 4 years ago

So you can actually click it to expand the menu items, you just can't see it

image

leeenglestone commented 4 years ago

@JamesLedger @seanstride

leeenglestone commented 4 years ago

Have you seen this @JamesLedger ?

JamesLedger commented 4 years ago

Ah apologies meant to say - I've been away camping for a bit. I'll be back late Monday so will take a look Tuesday

leeenglestone commented 4 years ago

Cheers @JamesLedger. No rush

InocentumAbhijit commented 4 years ago

Please consider checking my PR #40

leeenglestone commented 4 years ago

@InocentumAbhijit There was another recent PR done to put the theme toggle in the top right. Does your branch accommodate for this as you are putting the menu back in the top right?

InocentumAbhijit commented 4 years ago

image image

Here is what I have done

Do you want to change anything here ?

leeenglestone commented 4 years ago

Looks good. @InocentumAbhijit .

Would you mind trying to swap the menu and theme toggle around? So menu is at the top right?

That would be appreciated.

-- Lee

InocentumAbhijit commented 4 years ago

image image

New implementation

leeenglestone commented 4 years ago

Hi @InocentumAbhijit I'm not seeing the hamburger menu on local chrome or safari. Can check you've committed all your changes?

InocentumAbhijit commented 4 years ago

Hi, I just have updated the site.css file inside wwwroot/css folder and have not touched any other file. I think there might be a css override after building and running the application. Actually I do not have much knowledge about .NET building process.

Okay, I find out the issue, fixing that with a new commit. The issue is with a comment that I did in site.css file, sorry for that.

Done #42