search

lefticus / cpp_weekly_game_project

The Unlicense
107 stars 22 forks source link

Error when building with MSVC #15

Open FusionOpz opened 4 years ago

FusionOpz commented 4 years ago

There's an error with MSVC when compiling without the /experimental:module flag.

Will not compile due to the following code being unstupported by MSVC:

constexpr std::array steps = { "The Plan",
    "Getting Started",
    "Finding Errors As Soon As Possible",
    "Handling Command Line Parameters",
    "C++ 20 So Far",
    "Reading SFML Input States",
    "Managing Game State",
    "Making Our Game Testable",
    "Making Game State Allocator Aware",
    "Add Logging To Game Engine",
    "Draw A Game Map",
    "Dialog Trees",
    "Porting From SFML To SDL" };
ddalcino commented 4 years ago

Really? Can you double-check that you’re on VS 2019? That particular line has a lot of trouble compiling if your compiler doesn’t fully support c++17, and VS2019 is the first VS to do so.

See appveyor build for confirmation that this line did work. I’m not sure about the current status though; there’s some new code for episode 6 I haven’t seen yet.

See cppreference documentation of which compilers support which for standards.

Edit to correct myself: VS2019 is not the first Visual Studio to fully support C++17; apparently, VS2017 did, but the cppreference page makes it difficult to see this. That page appears to show 'Version 19' for everything, but when you hover over the number, it shows you "VS 2015 version 14.x", "VS 2017 version 15.x", or "VS 2019 version 16.x". I can prove that VS 2019 compiles this line properly; I don't know about the earlier versions, but I expect that many of them cannot.

FusionOpz commented 4 years ago

I'm for sure on VS2019 16.5.5, /std:c++latest is set, platform tools is set to Visual Studio 2019 (142) , but if I don't set the /experimental:module flag I get compiler errors.

Ugh and now I can't reproduce it myself...

ddalcino commented 4 years ago

Maybe run a git diff to see if there's something you changed? The most recent commit doesn't compile for me on VS unless I add #include <optional> to src/Input.hpp; I imagine you must have made this change or something like it. Maybe you tried adding one of the experimental modules to get it to work?