search

legacysurvey / legacypipe

Image reduction pipeline for the DESI Legacy Imaging Surveys, using the Tractor framework
BSD 3-Clause "New" or "Revised" License
37 stars 22 forks source link

Generation of Imaging Templates #655

Closed mehdirezaie closed 4 years ago

mehdirezaie commented 4 years ago

We would like to make the code for generating the imaging templates, in particular MJD, Airmass, and Nobs 'public'. The underlying code is built upon QuickSip, developed by Boris Lesitedt for the Dark Energy Survey. It is modified by Marc Manera (@manera), Ashley Ross (@ashleyjross), Hee-Jong Seo et al to adopt to the DESI Legacy Imaging Surveys. The functionality has been depreciated to only create the imaging templates, and not perform validation tests.

For a demo see this notebook

dstndstn commented 4 years ago

Hi Mehdi,

Thanks for this! Are you ready for it to be merged?

mehdirezaie commented 4 years ago

Hi Dustin!

The caveat is that currently the code does not work for the mean number of observation (nobs). We can merge it if you think it's ok to work on nobs later.

For now I have put a placeholder for nobs. I think to resolve this, the code must be modified to allow oversampling of HEALPix pixels. We can wait to hear back from @ashleyjross or @manera.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.006%) to 76.18% when pulling ded0def21c7debd522b18a447f11d43c2963ac7d on mehdirezaie:master into ca15a680dc34050370a8716acb5a21460230028c on legacysurvey:master.

dstndstn commented 4 years ago

Okay, thanks! I'll merge now, you can always update the nobs part later.