search

legacysurvey / legacypipe

Image reduction pipeline for the DESI Legacy Imaging Surveys, using the Tractor framework
BSD 3-Clause "New" or "Revised" License
37 stars 22 forks source link

Bright star mask with zguess #697

Closed rongpu closed 3 years ago

rongpu commented 3 years ago

For very red stars, the mask magnitude is zguess for Tycho-2, but for it's (zguess+1) for GAIA. It this difference intended?

dstndstn commented 3 years ago

Oh, well spotted! For the Tycho-2 one, we're setting up to do a nan-ignoring version of the mask_mag = np.minimum(mask_mag, zguess+1), but then we don't do the +1 when actually updating it!

I'm sure this much have just been an oversight.

So that means we're using a larger mask radius for red Tycho-2 stars. And since we match Tycho-2 to Gaia and drop the Tycho-2 entry for those that match, this will affect Tycho-2-only stars.

dstndstn commented 3 years ago

(sorry, accidentally hit the CLOSE button!)

dstndstn commented 3 years ago

Addressed in 0467d71e

rongpu commented 3 years ago

Thanks for clarifying and for the fix!