State of highlighting button not distinguishable with Autralis

[GoogleCodeExporter]

With the new Autralis theme introduced in Firefox 29.0, the button to 
enable/disable highlighting always looks the same, regardless whether the 
button is checked or not.

That means one can't tell whether highlighting is enabled (checked="true") or 
disabled (checked="false").

Original issue reported on code.google.com by Eduard.Braun2 on 4 May 2014 at 9:27

[GoogleCodeExporter]

This is a temporary workaround (found on this site: 
http://anago.2ch.net/test/read.cgi/software/1391796162/317)

Add the following to your userChrome.css 
(http://kb.mozillazine.org/UserChrome.css)

/* Fix SearchWP button state */
#nav-bar 
#searchwp-highlight-button[checked="false"]:not(:-moz-any([disabled],:hover,:act
ive)) > .toolbarbutton-icon{
background-image:none !important;
background-color: hsla(210,32%,93%,0) !important;
border-color: hsla(210,54%,20%,0) hsla(210,54%,20%,0) hsla(210,54%,20%,0) 
!important;
box-shadow: 0 1px hsla(0,0%,100%,0) inset,
0 1px hsla(210,54%,20%,0),
0 0 2px hsla(210,54%,20%,0) !important;
transition-property: background-color, border-color, box-shadow !important;
transition-duration: 150ms !important;
} 

Don't forget to remove this when/if the author fixes the issue.

Original comment by ivel...@gmail.com on 7 May 2014 at 9:51

[GoogleCodeExporter]

Find attached a patch which solves this issue with minimal custom CSS needed.

Basically - instead of setting the "checked" attribute to true and false - this 
patch removes the attribute completely when not true. This is the behaviour 
suggested on MDN [1], is backwards compatible to older Firefox versions, but 
also works in newer Australis themed Firefox versions

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/checked

Original comment by Eduard.Braun2 on 30 Jul 2014 at 7:02

Attachments:

• highlight-button.diff

[GoogleCodeExporter]

Fixed in r236.

Original comment by Eduard.Braun2 on 12 Aug 2014 at 9:19

• Changed state: Fixed