legend-exp / legend-pygeom-hpges

Germanium detector geometries for radiation transport simulations
https://legend-pygeom-hpges.readthedocs.io
GNU General Public License v3.0
0 stars 4 forks source link

Handling null enrichment/name argument in the metadata when user overrides the material and name of the detector #10

Closed nikolay327 closed 1 year ago

nikolay327 commented 1 year ago

Making make_hpge able to handle null enrichment/name argument in the metadata when material and name are supplied by the user

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 80.00% and project coverage change: +2.31 :tada:

Comparison is base (a5d5096) 72.84% compared to head (2349c0f) 75.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10 +/- ## ========================================== + Coverage 72.84% 75.16% +2.31% ========================================== Files 11 11 Lines 302 310 +8 ========================================== + Hits 220 233 +13 + Misses 82 77 -5 ``` | [Impacted Files](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp) | Coverage Δ | | |---|---|---| | [src/legendhpges/make\_hpge.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL21ha2VfaHBnZS5weQ==) | `91.89% <80.00%> (-1.22%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/10/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

gipert commented 1 year ago

Instead of adding a whole new JSON config for this test, can you just load the existing one and set enrichment = None before passing is to make_hpge?