legend-exp / legend-pygeom-hpges

Germanium detector geometries for radiation transport simulations
https://legend-pygeom-hpges.readthedocs.io
GNU General Public License v3.0
0 stars 4 forks source link

Make changes in the base class, add P00664B and improve make_hpge #12

Closed nikolay327 closed 1 year ago

nikolay327 commented 1 year ago
nikolay327 commented 1 year ago

Dummy values are used to construct the following: Screenshot (47)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 87.50% and project coverage change: +2.31 :tada:

Comparison is base (971fda7) 74.17% compared to head (0b16ec2) 76.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12 +/- ## ========================================== + Coverage 74.17% 76.48% +2.31% ========================================== Files 11 12 +1 Lines 333 387 +54 ========================================== + Hits 247 296 +49 - Misses 86 91 +5 ``` | [Impacted Files](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp) | Coverage Δ | | |---|---|---| | [src/legendhpges/p00664b.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL3AwMDY2NGIucHk=) | `84.61% <84.61%> (ø)` | | | [src/legendhpges/make\_hpge.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL21ha2VfaHBnZS5weQ==) | `95.00% <88.88%> (+1.89%)` | :arrow_up: | | [src/legendhpges/\_\_init\_\_.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [src/legendhpges/base.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL2Jhc2UucHk=) | `69.38% <100.00%> (+4.17%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.