legend-exp / legend-pygeom-hpges

Germanium detector geometries for radiation transport simulations
https://legend-pygeom-hpges.readthedocs.io
GNU General Public License v3.0
0 stars 4 forks source link

also implement reading enrichment from future metadata scheme #35

Closed ManuelHu closed 5 months ago

ManuelHu commented 5 months ago

after https://github.com/legend-exp/legend-detectors/pull/43, the enrichment is not stored as float, but as an object { "val": X, "unc": Y }

That change is not part of a tagged legend-metadata release yet, so this PR is not urgent.

Also change two return types to the correct values.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.74%. Comparing base (8962dfe) to head (a7c9b2c). Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
src/legendhpges/make_hpge.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== - Coverage 80.25% 79.74% -0.52% ========================================== Files 14 14 Lines 542 548 +6 ========================================== + Hits 435 437 +2 - Misses 107 111 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.