Closed tdixon97 closed 2 weeks ago
Attention: Patch coverage is 68.51852%
with 85 lines
in your changes missing coverage. Please review.
Project coverage is 77.86%. Comparing base (
a7c9b2c
) to head (ad7b135
). Report is 64 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
just an idea: maybe it would make sense to split utils into two parts; one that creates geometry (i.e. helpers for contacts, maybe spherical segments later on) and one for consuming geometry (i.e. calculating distances)?
Yes probably you are right
Another thing to take care of: I think that because of finite numerical precision some hits could be found outside the detector by a tiny amount -> we should push them back in
Another thing to take care of: I think that because of finite numerical precision some hits could be found outside the detector by a tiny amount -> we should push them back in
This is not necessarily so trivial, need to compute if a point is inside vs outside, i.e. attach a sign to the distance.
I left some comments.
All of this can be very easily sped up with Numba, let's do that.
Now done.
Any more issues? Can we merge this ?
for me it looks fine, we can always iterate later if we need to.
Should have now fixed your last comments @gipert
I have removed the pre-commit commits and pushed some cosmetic stuff, getting ready to merge
This implements a calculation of the distance between points and the surface.
We should also add.
generalization to asymmetric detectors (including the surface types), add later. Only P00664A, V02160A
But these could be added later since the correct exceptions are raised in these cases currently.