search

leichter / cwrx

(Old) Cinema6 API
0 stars 0 forks source link

Add additional metdata to image array for app store data #963

Closed oshanley closed 8 years ago

oshanley commented 8 years ago

script and e2e test only; unit test should be done soon

oshanley commented 8 years ago

fixes #953

oshanley commented 8 years ago

not sure why the jenkins build is failing since all the tests are successful and the linting passes... maybe I left out a test or something?

minznerjosh commented 8 years ago

Are you sure the tests are passing? They're failing in jenkins with: Cannot find module 'extend'.

oshanley commented 8 years ago

Ahh I wondered if it was that. I installed a new dependency, extend. What's the protocol for getting that change to reflect globally, again?

minznerjosh commented 8 years ago

One last thing!: Please update the changelog: https://github.com/cinema6/cwrx/blob/master/collateral_changelog.md

oshanley commented 8 years ago

Should I just add a [FEATURE] to it? Evan usually handled the deployment aspect

minznerjosh commented 8 years ago

Yup! Add a [FEATURE].