search

lemma-osu / sknnr

scikit-learn compatible estimators for various kNN imputation methods
https://sknnr.readthedocs.io
0 stars 1 forks source link

Simplify fit parameters for `CCATransformer` and `CCorATransformer` #31

Closed aazuspan closed 1 year ago

aazuspan commented 1 year ago

This will close #30 by:

  1. Making y a required parameter for fitting CCATransformer and CCorATransformer.
  2. Making GNNRegressor and MSNRegressor choose the appropriate fitting data instead of the transformer.
  3. Renaming spp to y_fit throughout.
grovduck commented 1 year ago

This looks great. Ignore the commit reference above. I was trying to follow your convention of referencing both the issue and PR numbers in the commit title, but I think you sneaked this commit in there before I did ;). I ended up amending my commit message, but alas too late for this.

Let's get this one merged first as I think it will have some breaking changes in #32 with the spp vs y_fit parameter.

aazuspan commented 1 year ago

Let's get this one merged first as I think it will have some breaking changes in https://github.com/lemma-osu/scikit-learn-knn-regression/pull/32 with the spp vs y_fit parameter.

Sounds good, thanks!