search

lemonmade / bigfoot

A jQuery plugin for creating exceptional footnotes.
http://www.bigfootjs.com
MIT License
936 stars 69 forks source link

bigfoot.js popup overflowing #66

Open kulbhushanchand opened 5 years ago

kulbhushanchand commented 5 years ago

Hi @lemonmade

I just notices a bug with bigfoot while implementing on my website

Bug - On mobile device (my mobile screen res - 720x1280), the popup overflow from the screen if footnote is placed on extreme left on the screen.

I tried using positionContent: "true" as mentioned on http://bigfootjs.com but no success.

Maybe I also found this opened issue (on this same repo) which might be the same -https://github.com/lemonmade/bigfoot/issues/46

I opened same issue https://github.com/mmistakes/made-mistakes-jekyll/issues/631 (please do check this link for our detailed conversation regarding this issue), where the author kindly helped me to test the issue, but we were not able to find the source of bug.

Explanation -

On my website - this page - happens on mobile device only

screenshot_20181001-073003

kulbhushanchand commented 5 years ago

I narrowed down to the part may be responsible for this bug. I checked the javascript code and tried to understand if I can call this function at the time of popover creation, but my limited knowledge of javascript plays a hindrance. 🤔

2018-10-02_18-26-17

donaldboulton commented 5 years ago

Check your .scss works at donboulton.com but you are right its not responsive when you resize the window, unless you close and reopen it.

kulbhushanchand commented 5 years ago

@donaldboulton Thanks for reply. I have checked your website github repo, and was not able to figure out how you have managed to rectify this problem. The funny thing is that this bug does not occurs on samsung native native webbrowser (on android phone) and safari/chrome on iPhone. 🤔