lennoxtr / pe

0 stars 0 forks source link

Listing all leaves by employee is misleading #1

Open lennoxtr opened 1 year ago

lennoxtr commented 1 year ago

Descriptions:

Listing all leaves by an employee id only updates the leave window without updating the employee windows, resulting in the user thinking that the program did not update anything after execution. Hence, the user might think that all of these employee has taken leave on the specified date

Steps to reproduce:

aetl eid/2 d/2022-03-31

list

llbe eid/2

Expected result:

Leaves of employee with eid 2 is shown, and employee with eid 2 is shown in the employee list

Actual result:

Program shows no result after execution

image.png

Other details

None

Error output

None

nus-se-script commented 1 year ago

Team's Response

We have already addressed this in our planned enhancements:

Screenshot 2023-04-17 at 7.23.18 PM.png

Also, the command still does what it is supposed to do based on our UG.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I believe that the severity should be Medium. As per textbook: - severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only. - severity.Medium : A flaw that causes occasional inconvenience to some users but they can continue to use the product. Since the program is marketed as a means to allow HR personnel to manage an extensive database of employee data, the HR person would be expected to use the "listing leave by employees" feature on a regular basis. This could be to count an employee's total working days to calculate monthly salary or bonus. It could also be to check whether an employee has exceeded the total number of leaves allowed. Since there is a large number of employees, and the bug appears every time the command is executed, it cannot be said that the bug would only appear in very rare situations and therefore does not correspond to the requirements of severity.Low. When the bug appears, the HR person would get quite confused as according to the program's window, intuitively, all of the listed employees would be taking leave on that day. They may also not know whether the command has been executed successfully. This does not affect the HR person's usage of the product, but I argue that it would not cause a minor inconvenience, as HR people have quite stressful jobs and have to manage the data of a large number of employees. Having a more intuitive window would help them a lot more with their job. This corresponds to severity.Medium's requirements.