feat: Open external links on navto

lenra-io / devtool

GNU Affero General Public License v3.0

5 stars 1 forks source link

feat: Open external links on navto #188

Closed jonas-martinez closed 1 year ago

jonas-martinez commented 1 year ago

Closes #

Description of the changes

Checklist

[x] I didn't over-scope my PR
[x] My PR title matches the commit convention
[x] I did not include breaking changes
[x] I made my own code-review before requesting one

I included unit tests that cover my changes

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

I added/updated the documentation about my changes

[ ] 📜 README.md
[ ] 📕 docs/*.md
[ ] 📓 docs.lenra.io
[x] 🙅 no documentation needed

Technical highlight/advice

jonas-martinez commented 1 year ago

Uncaught MissingPluginException(No implementation found for method launch on channel plugins.flutter.io/url_launcher)

jonas-martinez commented 1 year ago

https://stackoverflow.com/questions/50459272/missingpluginexception-while-using-plugin-for-flutter

jonas-martinez commented 1 year ago

It seems to work now, I needed to run a flutter clean before the flutter build web. Apparently this is a known issue on Flutter and this is the fix.

taorepoara commented 1 year ago

I'll test it this afternoon

shiipou commented 1 year ago

:tada: This PR is included in version 1.0.0-alpha.6 :tada:

The release is available on:

GitHub release
v1.0.0-alpha.6

Your semantic-release bot :package::rocket: