fix: Webhooks trigger render error

jonas-martinez commented 9 months ago

About this PR

Closes https://github.com/lenra-io/devtool/issues/214

The problem was coming from the fact that we did not have a default View to render our controller results. I simply added the default view BaseView from the lenra_common lib and now it properly works. No error is shown in the console when triggering a webhook.

I've also added a default error view "FallbackController" just in case.

Technical highlight/advice

How to test my changes

Checklist

[x] I didn't over-scope my PR
[x] My PR title matches the commit convention
[x] I did not include breaking changes
[x] I made my own code-review before requesting one

I included unit tests that cover my changes

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

I added/updated the documentation about my changes

[ ] 📜 README.md
[ ] 📕 docs/*.md
[ ] 📓 docs.lenra.io
[x] 🙅 no documentation needed

taorepoara commented 8 months ago

You should add a unit test to make sure that the problem won't come back

shiipou commented 8 months ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on:

GitHub release
v1.2.1

Your semantic-release bot :package::rocket:

lenra-io / devtool