leoding86 / webextension-pixiv-toolkit

A web extension for Pixiv
1.46k stars 88 forks source link

Wrong download order (first and second image are swapped, and other) #220

Open Hlebuw3k opened 2 years ago

Hlebuw3k commented 2 years ago

Describe the bug Sometimes when downloading multiple images, the second image (named XXX_p1) will be downloaded before the first image (named XXX_p0), and other weird order behaviour with Select & DL every image except the first one.

Expected behavior The first image should be downloaded before the second image, to keep the correct order. All the images should be downloaded in the order that is shown on the page.

Example work from Pixiv NSFW R18+ https://www.pixiv.net/en/artworks/85397385 Download p1-p29; Select & DL all except the first image

Screenshots Screenshots of the download order jumping from 19 to 2 to 20 and other similar cases. Снимок экрана 2022-10-20 035508 Снимок экрана 2022-10-20 035450 Снимок экрана 2022-10-20 035437

Browser and Version (please complete the following information): Chrome, 106.0.5249.119, 64 bit, Windows 10 Pro

Settings of extension Note: This happens with very high download delay between each image, e.g. 4000 ms, it also happens with low delay. pixiv_toolkit_settings-1666227642070.zip

Additional context I thought it might happen because of multi-threaded downloads, but i have no idea how it works, or if its even a thing, all i can do is give more testing when needed.